Skip to content

Commit 47647f6

Browse files
committed
restore operator delete NYI diagnostics and drop redundant lowering test
1 parent c8e3813 commit 47647f6

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ void CIRGenFunction::emitNewArrayInitializer(
421421
if (!e->hasInitializer())
422422
return;
423423

424-
llvm_unreachable("NYI");
424+
cgm.errorNYI(e->getSourceRange(), "emitNewArrayInitializer");
425425
}
426426

427427
static void emitNewInitializer(CIRGenFunction &cgf, const CXXNewExpr *e,
@@ -700,10 +700,9 @@ mlir::Value CIRGenFunction::emitCXXNewExpr(const CXXNewExpr *e) {
700700

701701
// If there's an operator delete, enter a cleanup to call it if an
702702
// exception is thrown.
703-
// TODO: Handle operator delete cleanup for exception safety
704-
// if (e->getOperatorDelete() &&
705-
// !e->getOperatorDelete()->isReservedGlobalPlacementOperator())
706-
// cgm.errorNYI(e->getSourceRange(), "emitCXXNewExpr: operator delete");
703+
if (e->getOperatorDelete() &&
704+
!e->getOperatorDelete()->isReservedGlobalPlacementOperator())
705+
cgm.errorNYI(e->getSourceRange(), "emitCXXNewExpr: operator delete");
707706

708707
if (allocSize != allocSizeWithoutCookie)
709708
cgm.errorNYI(e->getSourceRange(), "emitCXXNewExpr: array with cookies");

clang/test/CIR/Lowering/new.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)