Skip to content

Commit 4427cdb

Browse files
committed
To address review comments to simplify the code.
1 parent c4b4b43 commit 4427cdb

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

flang/lib/Optimizer/Builder/TemporaryStorage.cpp

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -258,19 +258,9 @@ void fir::factory::AnyVariableStack::pushValue(mlir::Location loc,
258258
fir::FirOpBuilder &builder,
259259
mlir::Value variable) {
260260
hlfir::Entity entity{variable};
261-
if (mlir::isa<fir::BaseBoxType>(entity.getType())) {
262-
mlir::Value box =
263-
hlfir::genVariableBox(loc, builder, entity, entity.getBoxType());
264-
fir::runtime::genPushDescriptor(loc, builder, opaquePtr, fir::getBase(box));
265-
} else {
266-
mlir::Type storageElementType =
267-
hlfir::getFortranElementType(retValueBox.getType());
268-
auto [box, maybeCleanUp] =
269-
hlfir::convertToBox(loc, builder, entity, storageElementType);
270-
fir::runtime::genPushDescriptor(loc, builder, opaquePtr, fir::getBase(box));
271-
if (maybeCleanUp)
272-
(*maybeCleanUp)();
273-
}
261+
mlir::Value box =
262+
hlfir::genVariableBox(loc, builder, entity, entity.getBoxType());
263+
fir::runtime::genPushDescriptor(loc, builder, opaquePtr, fir::getBase(box));
274264
}
275265

276266
void fir::factory::AnyVariableStack::resetFetchPosition(

0 commit comments

Comments
 (0)