Skip to content

Commit 37a4d9d

Browse files
committed
Address review comments
1 parent 9f6d65c commit 37a4d9d

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

clang/lib/CodeGen/CodeGenModule.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,8 @@ void CodeGenModule::Release() {
11921192
getModule().addModuleFlag(llvm::Module::Min,
11931193
"sign-return-address-with-bkey", 1);
11941194

1195-
if (getTriple().isOSLinux() && getTriple().isOSBinFormatELF()) {
1195+
if (getTriple().isOSLinux()) {
1196+
assert(getTriple().isOSBinFormatELF());
11961197
using namespace llvm::ELF;
11971198
uint64_t PAuthABIVersion =
11981199
(LangOpts.PointerAuthIntrinsics

clang/test/CodeGen/aarch64-elf-pauthabi.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
1+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
22
// RUN: -fptrauth-intrinsics \
33
// RUN: -fptrauth-calls \
44
// RUN: -fptrauth-returns \
@@ -8,27 +8,27 @@
88
// RUN: -fptrauth-init-fini %s | \
99
// RUN: FileCheck %s --check-prefix=ALL
1010

11-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
11+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
1212
// RUN: -fptrauth-intrinsics %s | FileCheck %s --check-prefix=INTRIN
1313

14-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
14+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
1515
// RUN: -fptrauth-calls %s | FileCheck %s --check-prefix=CALL
1616

17-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
17+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
1818
// RUN: -fptrauth-returns %s | FileCheck %s --check-prefix=RET
1919

20-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
20+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
2121
// RUN: -fptrauth-auth-traps %s | FileCheck %s --check-prefix=TRAP
2222

23-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
23+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
2424
// RUN: -fptrauth-calls -fptrauth-vtable-pointer-address-discrimination %s | \
2525
// RUN: FileCheck %s --check-prefix=VPTRADDR
2626

27-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
27+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
2828
// RUN: -fptrauth-calls -fptrauth-vtable-pointer-type-discrimination %s | \
2929
// RUN: FileCheck %s --check-prefix=VPTRTYPE
3030

31-
// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
31+
// RUN: %clang_cc1 -triple aarch64-linux -emit-llvm -o - \
3232
// RUN: -fptrauth-calls -fptrauth-init-fini %s | \
3333
// RUN: FileCheck %s --check-prefix=INITFINI
3434

0 commit comments

Comments
 (0)