Skip to content

Commit 2e686d6

Browse files
authored
[libc++] Remove workaround which allows setting _LIBCPP_OVERRIDABLE_FUNC_VIS externally (#113139)
`-fvisibility-global-new-delete` has been added in Clang 18, so there is no more need to specify the visibility of new/delete via libc++-internal macros. Some people used a custom new/delete, which requires them to have default visibility, but didn't want to leak any symbols otherwise. Since the new/delete visibility can now be controlled by a compiler flag, there is no reason to set it with out macro. https://reviews.llvm.org/D128007 originally tried to remove the option to override the macro, but was partially reverted because people actually set this specific macro.
1 parent 522f34c commit 2e686d6

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

libcxx/include/__config

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -408,11 +408,7 @@ typedef __char32_t char32_t;
408408
# define _LIBCPP_EXPORTED_FROM_ABI _LIBCPP_VISIBILITY("default")
409409
# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS _LIBCPP_VISIBILITY("default")
410410
# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS
411-
412-
// TODO: Make this a proper customization point or remove the option to override it.
413-
# ifndef _LIBCPP_OVERRIDABLE_FUNC_VIS
414-
# define _LIBCPP_OVERRIDABLE_FUNC_VIS _LIBCPP_VISIBILITY("default")
415-
# endif
411+
# define _LIBCPP_OVERRIDABLE_FUNC_VIS _LIBCPP_VISIBILITY("default")
416412

417413
# if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
418414
// The inline should be removed once PR32114 is resolved

0 commit comments

Comments
 (0)