Skip to content

Commit 214ce4d

Browse files
authored
[MLIR][Transform] Fix PrintOp::build with StringRef (#67052)
transform::PrintOp::build(OpBuilder &builder, OperationState &result, StringRef name) does not set name correctly. Calling PrintOp::build(builder, result, "whatever name") is going to end up with a PrintOp with no name. This patch fixes it by replicating the approach from tablegen created code. Refer to build/mlir/include/mlir/Dialect/Transform/IR/TransformOps.cpp.inc
1 parent 0564065 commit 214ce4d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

mlir/lib/Dialect/Transform/IR/TransformOps.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2311,10 +2311,8 @@ void transform::SequenceOp::build(OpBuilder &builder, OperationState &state,
23112311

23122312
void transform::PrintOp::build(OpBuilder &builder, OperationState &result,
23132313
StringRef name) {
2314-
if (!name.empty()) {
2315-
result.addAttribute(PrintOp::getNameAttrName(result.name),
2316-
builder.getStrArrayAttr(name));
2317-
}
2314+
if (!name.empty())
2315+
result.getOrAddProperties<Properties>().name = builder.getStringAttr(name);
23182316
}
23192317

23202318
void transform::PrintOp::build(OpBuilder &builder, OperationState &result,

0 commit comments

Comments
 (0)