Skip to content

Commit 1cfe5b8

Browse files
authored
[lldb] Use SEND_ERROR instead of FATAL_ERROR in test/CMakeLists.txt (#111729)
Use SEND_ERROR (continue processing, but skip generation) instead of FATAL_ERROR (stop processing and generation). This means that developers get to see all errors at once, instead of seeing just the first error and having to reconfigure to discover the next one.
1 parent 1bb52e9 commit 1cfe5b8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lldb/test/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Lit requires a Python3 interpreter, let's be careful and fail early if it's
44
# not present.
55
if (NOT DEFINED Python3_EXECUTABLE)
6-
message(FATAL_ERROR
6+
message(SEND_ERROR
77
"LLDB test suite requires a Python3 interpreter but none "
88
"was found. Please install Python3 or disable tests with "
99
"`LLDB_INCLUDE_TESTS=OFF`.")
@@ -22,7 +22,7 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
2222
foreach(module ${useful_python_modules})
2323
lldb_find_python_module(${module})
2424
if (NOT PY_${module}_FOUND)
25-
message(FATAL_ERROR
25+
message(SEND_ERROR
2626
"Python module '${module}' not found. Please install it via pip or via "
2727
"your operating system's package manager. Alternatively, disable "
2828
"strict testing requirements with "
@@ -66,10 +66,10 @@ if (LLDB_TEST_OBJC_GNUSTEP)
6666
find_package(GNUstepObjC)
6767
if (NOT GNUstepObjC_FOUND)
6868
if (LLDB_TEST_OBJC_GNUSTEP_DIR)
69-
message(FATAL_ERROR "Failed to find GNUstep libobjc2 in ${LLDB_TEST_OBJC_GNUSTEP_DIR}. "
69+
message(SEND_ERROR "Failed to find GNUstep libobjc2 in ${LLDB_TEST_OBJC_GNUSTEP_DIR}. "
7070
"Please check LLDB_TEST_OBJC_GNUSTEP_DIR or turn off LLDB_TEST_OBJC_GNUSTEP.")
7171
else()
72-
message(FATAL_ERROR "Failed to find GNUstep libobjc2. "
72+
message(SEND_ERROR "Failed to find GNUstep libobjc2. "
7373
"Please set LLDB_TEST_OBJC_GNUSTEP_DIR or turn off LLDB_TEST_OBJC_GNUSTEP.")
7474
endif()
7575
endif()
@@ -185,7 +185,7 @@ if(TARGET clang)
185185
set(LIBCXX_LIBRARY_DIR "${LLDB_TEST_LIBCXX_ROOT_DIR}/lib${LIBCXX_LIBDIR_SUFFIX}")
186186
set(LIBCXX_GENERATED_INCLUDE_DIR "${LLDB_TEST_LIBCXX_ROOT_DIR}/include/c++/v1")
187187
else()
188-
message(FATAL_ERROR
188+
message(SEND_ERROR
189189
"Couldn't find libcxx build in '${LLDB_TEST_LIBCXX_ROOT_DIR}'. To run the "
190190
"test-suite for a standalone LLDB build please build libcxx and point "
191191
"LLDB_TEST_LIBCXX_ROOT_DIR to it.")
@@ -194,7 +194,7 @@ if(TARGET clang)
194194
# We require libcxx for the test suite, so if we aren't building it,
195195
# provide a helpful error about how to resolve the situation.
196196
if(NOT LLDB_HAS_LIBCXX)
197-
message(FATAL_ERROR
197+
message(SEND_ERROR
198198
"LLDB test suite requires libc++, but it is currently disabled. "
199199
"Please add `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via "
200200
"`LLDB_INCLUDE_TESTS=OFF`.")

0 commit comments

Comments
 (0)