Skip to content

Commit 1a4c19d

Browse files
[ProfCheck] Mark Some profverify Tests as Unsupported (#167544)
These tests fail in the profcheck configuration because profinject gets added to the pipeline and adds metadata that changes the input PGO information.
1 parent 04df359 commit 1a4c19d

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

llvm/test/Transforms/PGOProfile/prof-verify-no-entrycount.ll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
; This test fails under the profcheck configuration due to profcheck creating
2+
; metadata.
3+
; UNSUPPORTED: profcheck
4+
15
; Test prof-verify for functions without entry count
26

37
; RUN: not opt -passes=prof-verify %s -o - 2>&1 | FileCheck %s

llvm/test/Transforms/PGOProfile/prof-verify.ll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
; This test fails under the profcheck configuration due to profcheck creating
2+
; metadata.
3+
; UNSUPPORTED: profcheck
4+
15
; Test prof-inject and prof-verify
26

37
; RUN: opt -passes=prof-inject %s -S -o - | FileCheck %s --check-prefix=INJECT

llvm/test/Transforms/PGOProfile/profcheck-select.ll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
; This test fails under the profcheck configuration due to profcheck creating
2+
; metadata.
3+
; UNSUPPORTED: profcheck
4+
15
; RUN: split-file %s %t
26

37
; RUN: opt -passes=prof-inject %t/inject.ll -S -o - | FileCheck %t/inject.ll

llvm/test/lit.cfg.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@
6969
# profiling doesn't work quite well on GPU, excluding
7070
config.excludes.append("AMDGPU")
7171

72+
config.available_features.add("profcheck")
73+
7274
# test_source_root: The root path where tests are located.
7375
config.test_source_root = os.path.dirname(__file__)
7476

llvm/utils/profcheck-xfail.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -614,9 +614,6 @@ Transforms/PGOProfile/chr-lifetimes.ll
614614
Transforms/PGOProfile/chr-poison.ll
615615
Transforms/PGOProfile/comdat.ll
616616
Transforms/PGOProfile/memop_profile_funclet_wasm.ll
617-
Transforms/PGOProfile/profcheck-select.ll
618-
Transforms/PGOProfile/prof-verify.ll
619-
Transforms/PGOProfile/prof-verify-no-entrycount.ll
620617
Transforms/PGOProfile/X86/macho.ll
621618
Transforms/PhaseOrdering/AArch64/constraint-elimination-placement.ll
622619
Transforms/PhaseOrdering/AArch64/globals-aa-required-for-vectorization.ll

0 commit comments

Comments
 (0)