Skip to content

Commit 01d7ece

Browse files
committed
[workflows] Fix argument passing in abi-dump jobs (#79658)
This was broken by 859e6aa, which added quotes around the EXTRA_ARGS variable.
1 parent 2765447 commit 01d7ece

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/llvm-tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
else
126126
touch llvm.symbols
127127
fi
128-
abi-dumper "$EXTRA_ARGS" -lver ${{ matrix.ref }} -skip-cxx -public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS }} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
128+
abi-dumper $EXTRA_ARGS -lver ${{ matrix.ref }} -skip-cxx -public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS }} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
129129
# Remove symbol versioning from dumps, so we can compare across major versions.
130130
sed -i 's/LLVM_${{ matrix.llvm_version_major }}/LLVM_NOVERSION/' ${{ matrix.ref }}.abi
131131
- name: Upload ABI file
@@ -175,7 +175,7 @@ jobs:
175175
# FIXME: Reading of gzip'd abi files on the GitHub runners stop
176176
# working some time in March of 2021, likely due to a change in the
177177
# runner's environment.
178-
abi-compliance-checker "$EXTRA_ARGS" -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
178+
abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
179179
- name: Upload ABI Comparison
180180
if: always()
181181
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)