Skip to content

Fix XFAIL in ptrstride.cir #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lanza opened this issue Oct 2, 2024 · 1 comment
Closed

Fix XFAIL in ptrstride.cir #912

lanza opened this issue Oct 2, 2024 · 1 comment

Comments

@lanza
Copy link
Member

lanza commented Oct 2, 2024

During rebasing this test began to fail.

smeenai added a commit to smeenai/clangir that referenced this issue Oct 8, 2024
I'm not sure how this was working before, but the stride can also be a
block argument and not have a defining op, so we also need to account
for that.

Fixes llvm#912
smeenai added a commit to smeenai/clangir that referenced this issue Oct 11, 2024
After recent rebases, the LLVMIR stride operand can be generated by an
unrealized_conversion_cast whereas the CIR operand is coming directly
from a block argument (and thus has no defining op), so we need to
separately check the CIR operand for the existence of a defining op.

Fixes llvm#912
@smeenai
Copy link
Collaborator

smeenai commented Oct 14, 2024

#947 fixed this, dunno why it didn't get auto-closed.

@smeenai smeenai closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants