Skip to content

Commit fc3b818

Browse files
committed
namings
1 parent f6cb7b2 commit fc3b818

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

clang/include/clang/CIR/Dialect/IR/CIROps.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2920,7 +2920,7 @@ def ExtractMemberOp : CIR_Op<"extract_member", [Pure]> {
29202920
```
29212921
}];
29222922

2923-
let arguments = (ins Struct:$record, IndexAttr:$index_attr);
2923+
let arguments = (ins CIRStructType:$record, IndexAttr:$index_attr);
29242924
let results = (outs CIR_AnyType:$result);
29252925

29262926
let assemblyFormat = [{
@@ -2984,9 +2984,9 @@ def InsertMemberOp : CIR_Op<"insert_member",
29842984
```
29852985
}];
29862986

2987-
let arguments = (ins Struct:$record, IndexAttr:$index_attr,
2987+
let arguments = (ins CIRStructType:$record, IndexAttr:$index_attr,
29882988
CIR_AnyType:$value);
2989-
let results = (outs Struct:$result);
2989+
let results = (outs CIRStructType:$result);
29902990

29912991
let builders = [
29922992
OpBuilder<(ins "mlir::Value":$record, "uint64_t":$index,

clang/include/clang/CIR/Dialect/IR/CIRTypes.td

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,9 @@ def CIR_StructType : CIR_Type<"Struct", "struct",
757757
let hasCustomAssemblyFormat = 1;
758758
}
759759

760-
def Struct : Type<CPred<"::mlir::isa<::cir::StructType>($_self)">, "CIR struct type">;
760+
// This type is used because of some limitations of type constraints.
761+
// See https://github.com/llvm/clangir/pull/1504#issuecomment-2738968751 for more details.
762+
def CIRStructType : Type<CPred<"::mlir::isa<::cir::StructType>($_self)">, "CIR struct type">;
761763

762764
//===----------------------------------------------------------------------===//
763765
// Global type constraints

0 commit comments

Comments
 (0)