Skip to content

Commit 8632753

Browse files
committed
remove one to one cases
1 parent 8d829ce commit 8632753

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -621,27 +621,7 @@ def DynamicCastInfoAttr
621621
// AddressSpaceAttr
622622
//===----------------------------------------------------------------------===//
623623

624-
// These keywords should always be sync with clang::LangAS
625-
def AS_OpenCLGlobal : I32EnumAttrCase<"opencl_global", 1>;
626-
def AS_OpenCLLocal : I32EnumAttrCase<"opencl_local", 2>;
627-
def AS_OpenCLConstant : I32EnumAttrCase<"opencl_constant", 3>;
628-
def AS_OpenCLPrivate : I32EnumAttrCase<"opencl_private", 4>;
629-
def AS_OpenCLGeneric : I32EnumAttrCase<"opencl_generic", 5>;
630-
def AS_OpenCLGlobalDevice : I32EnumAttrCase<"opencl_global_device", 6>;
631-
def AS_OpenCLGlobalHost : I32EnumAttrCase<"opencl_global_host", 7>;
632-
def AS_CUDADevice : I32EnumAttrCase<"cuda_device", 8>;
633-
def AS_CUDAConstant : I32EnumAttrCase<"cuda_constant", 9>;
634-
def AS_CUDAShared : I32EnumAttrCase<"cuda_shared", 10>;
635-
def AS_SYCLGlobal : I32EnumAttrCase<"sycl_global", 11>;
636-
def AS_SYCLGlobalDevice : I32EnumAttrCase<"sycl_global_device", 12>;
637-
def AS_SYCLGlobalHost : I32EnumAttrCase<"sycl_global_host", 13>;
638-
def AS_SYCLLocal : I32EnumAttrCase<"sycl_local", 14>;
639-
def AS_SYCLPrivate : I32EnumAttrCase<"sycl_private", 15>;
640-
def AS_Ptr32SPtr : I32EnumAttrCase<"ptr32_sptr", 16>;
641-
def AS_Ptr32UPtr : I32EnumAttrCase<"ptr32_uptr", 17>;
642-
def AS_Ptr64 : I32EnumAttrCase<"ptr64", 18>;
643-
def AS_HLSLGroupShared : I32EnumAttrCase<"hlsl_groupshared", 19>;
644-
def AS_WasmFuncref : I32EnumAttrCase<"wasm_funcref", 20>;
624+
// TODO: other CIR AS cases
645625
def AS_Target : I32EnumAttrCase<"target", 21>;
646626

647627
def AddressSpaceAttr : CIR_Attr<"AddressSpace", "addrspace"> {
@@ -679,11 +659,7 @@ def AddressSpaceAttr : CIR_Attr<"AddressSpace", "addrspace"> {
679659
// simplified assembly format `custom<PointerAddrSpace>`.
680660

681661
list<I32EnumAttrCase> langASCases = [
682-
AS_OpenCLGlobal, AS_OpenCLLocal, AS_OpenCLConstant, AS_OpenCLPrivate,
683-
AS_OpenCLGeneric, AS_OpenCLGlobalDevice, AS_OpenCLGlobalHost,
684-
AS_CUDADevice, AS_CUDAConstant, AS_CUDAShared, AS_SYCLGlobal,
685-
AS_SYCLGlobalDevice, AS_SYCLGlobalHost, AS_SYCLLocal, AS_SYCLPrivate,
686-
AS_Ptr32SPtr, AS_Ptr32UPtr, AS_Ptr64, AS_HLSLGroupShared, AS_WasmFuncref
662+
// TODO: includes all non-target CIR AS cases here
687663
];
688664

689665
I32EnumAttrCase targetASCase = AS_Target;

clang/test/CIR/IR/address-space.cir

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,4 @@ module {
1313
cir.func @test_format2(%arg0: !cir.ptr<!s32i>) {
1414
cir.return
1515
}
16-
17-
// CHECK: @test_format3(%arg0: !cir.ptr<!s32i, addrspace(opencl_private)>)
18-
cir.func @test_format3(%arg0: !cir.ptr<!s32i, addrspace(opencl_private)>) {
19-
cir.return
20-
}
2116
}

0 commit comments

Comments
 (0)