Skip to content
This repository was archived by the owner on Apr 23, 2020. It is now read-only.

Commit 9a7960e

Browse files
committed
Merging r339091:
------------------------------------------------------------------------ r339091 | stella.stamenova | 2018-08-07 06:08:46 +0200 (Tue, 07 Aug 2018) | 12 lines [lit, tests] Fix failing lit test: shtest-format.py Summary: The problem here is that on windows double quotes are used for paths (usually) while single quotes are not. This is not generally a problem for the tests because the lit infrastructure tends to treat both the same. One (and possibly only) exception is when some tests are run in an external shell such as some of the shtest-format tests. In this case on windows the path to python was not created correctly because it had single quotes and the test failed. This same test is already failing with python 3 which is why our testing missed the new failure. This patch will take care of the immediate failure with python 2 and I'll send a follow up for the python 3 failure. Reviewers: asmith, zturner Subscribers: delcypher, llvm-commits Differential Revision: https://reviews.llvm.org/D50373 ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_70@340349 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 1215ec5 commit 9a7960e

File tree

1 file changed

+1
-1
lines changed
  • utils/lit/tests/Inputs/shtest-format

1 file changed

+1
-1
lines changed

utils/lit/tests/Inputs/shtest-format/lit.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ config.test_source_root = None
66
config.test_exec_root = None
77
config.target_triple = 'x86_64-unknown-unknown'
88
config.available_features.add('a-present-feature')
9-
config.substitutions.append(('%{python}', "'%s'" % (sys.executable)))
9+
config.substitutions.append(('%{python}', '"%s"' % (sys.executable)))

0 commit comments

Comments
 (0)