Improve handling of package.json and other hidden files in Playground #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. https://pr461-34de3dd---lit-dev-5ftespv5na-uc.a.run.app/ |
AndrewJakubowicz
approved these changes
Aug 26, 2021
| content: content ?? '', | ||
| }; | ||
| if (hidden) { | ||
| compactFile.hidden = true; |
There was a problem hiding this comment.
Not actionable. I know that previously sharing would make the non visible package.json appear in the shared url. From manual testing I can see this no longer happens. Is that due to this assignment?
Also from manual testing this works great!
There was a problem hiding this comment.
Yep. Previously we never included hidden flags in the URL, whereas now we preserve them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Playground to bring in Creating a file that exists but is hidden now reveals the file google/playground-elements#197. This allows users to create a
package.jsoneven though by default we include a hidden one. Previously it was not possible to modify the package.json (except by exploiting the next bug, which is now fixed).Fix bug where we ignored the
hiddenflag when serializing project state to the URL.Add indentation to our default
package.jsonso that it's easier to read and modify when revealed.(Unrelated, I guess just result of regenerating package locks) Fix a typing error relating to
CSSResultGroupin one of the samples.