Skip to content

Fix Motion examples package.json formatting and trailing comma #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented May 22, 2023

Issue

Motion package.json samples have:

{
  "dependencies": {
    "lit": "^2.0.0",
    "@lit-labs/motion": "^1.0.1",  }
}

Which result in error: Invalid package.json: SyntaxError: Expected double-quoted property name in JSON at position 78.

Repro at: https://lit.dev/playground/#sample=examples/motion-list

Fix

Remove trailing comma.

Testing

This is a tidy up change as there was no user facing impact (unless they created a package.json). Tested manually by checking the motion samples still work locally.

@github-actions
Copy link

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1129-504d397---lit-dev-5ftespv5na-uc.a.run.app/

@AndrewJakubowicz AndrewJakubowicz requested a review from augustjk May 22, 2023 21:33
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AndrewJakubowicz AndrewJakubowicz merged commit 8329250 into main May 22, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the fix-motion-package-json branch May 22, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants