Skip to content

Fix comment about ref directive #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

Fix comment about ref directive #1126

merged 1 commit into from
May 19, 2023

Conversation

38elements
Copy link
Contributor

Following code is passing a change callback to ref directive, not passing ref directive to a change callback.

return html`<input ${ref(this.inputChanged)}>`;

AndrewJakubowicz
AndrewJakubowicz approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Agree that this is a clearer phrasing.

@AndrewJakubowicz AndrewJakubowicz merged commit 9e86ce3 into lit:main May 19, 2023
@38elements 38elements deleted the ref branch May 19, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@38elements @AndrewJakubowicz