Skip to content

Commit 28a1aae

Browse files
ehristevgregkh
authored andcommitted
iio: adc: at91: fix wrong channel number in triggered buffer mode
commit aea835f upstream. When channels are registered, the hardware channel number is not the actual iio channel number. This is because the driver is probed with a certain number of accessible channels. Some pins are routed and some not, depending on the description of the board in the DT. Because of that, channels 0,1,2,3 can correspond to hardware channels 2,3,4,5 for example. In the buffered triggered case, we need to do the translation accordingly. Fixed the channel number to stop reading the wrong channel. Fixes: 0e589d5 ("ARM: AT91: IIO: Add AT91 ADC driver.") Cc: Maxime Ripard <[email protected]> Signed-off-by: Eugen Hristev <[email protected]> Acked-by: Ludovic Desroches <[email protected]> Cc: <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent c4ecff9 commit 28a1aae

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/iio/adc/at91_adc.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,12 +248,14 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
248248
struct iio_poll_func *pf = p;
249249
struct iio_dev *idev = pf->indio_dev;
250250
struct at91_adc_state *st = iio_priv(idev);
251+
struct iio_chan_spec const *chan;
251252
int i, j = 0;
252253

253254
for (i = 0; i < idev->masklength; i++) {
254255
if (!test_bit(i, idev->active_scan_mask))
255256
continue;
256-
st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, i));
257+
chan = idev->channels + i;
258+
st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, chan->channel));
257259
j++;
258260
}
259261

0 commit comments

Comments
 (0)