Skip to content

Commit 13acc94

Browse files
yonghong-songdavem330
authored andcommitted
net: permit skb_segment on head_frag frag_list skb
One of our in-house projects, bpf-based NAT, hits a kernel BUG_ON at function skb_segment(), line 3667. The bpf program attaches to clsact ingress, calls bpf_skb_change_proto to change protocol from ipv4 to ipv6 or from ipv6 to ipv4, and then calls bpf_redirect to send the changed packet out. 3472 struct sk_buff *skb_segment(struct sk_buff *head_skb, 3473 netdev_features_t features) 3474 { 3475 struct sk_buff *segs = NULL; 3476 struct sk_buff *tail = NULL; ... 3665 while (pos < offset + len) { 3666 if (i >= nfrags) { 3667 BUG_ON(skb_headlen(list_skb)); 3668 3669 i = 0; 3670 nfrags = skb_shinfo(list_skb)->nr_frags; 3671 frag = skb_shinfo(list_skb)->frags; 3672 frag_skb = list_skb; ... call stack: ... kernel-patches#1 [ffff883ffef03558] __crash_kexec at ffffffff8110c525 kernel-patches#2 [ffff883ffef03620] crash_kexec at ffffffff8110d5cc kernel-patches#3 [ffff883ffef03640] oops_end at ffffffff8101d7e7 kernel-patches#4 [ffff883ffef03668] die at ffffffff8101deb2 kernel-patches#5 [ffff883ffef03698] do_trap at ffffffff8101a700 kernel-patches#6 [ffff883ffef036e8] do_error_trap at ffffffff8101abfe kernel-patches#7 [ffff883ffef037a0] do_invalid_op at ffffffff8101acd0 kernel-patches#8 [ffff883ffef037b0] invalid_op at ffffffff81a00bab [exception RIP: skb_segment+3044] RIP: ffffffff817e4dd4 RSP: ffff883ffef03860 RFLAGS: 00010216 RAX: 0000000000002bf6 RBX: ffff883feb7aaa00 RCX: 0000000000000011 RDX: ffff883fb87910c0 RSI: 0000000000000011 RDI: ffff883feb7ab500 RBP: ffff883ffef03928 R8: 0000000000002ce2 R9: 00000000000027da R10: 000001ea00000000 R11: 0000000000002d82 R12: ffff883f90a1ee80 R13: ffff883fb8791120 R14: ffff883feb7abc00 R15: 0000000000002ce2 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 kernel-patches#9 [ffff883ffef03930] tcp_gso_segment at ffffffff818713e7 Signed-off-by: David S. Miller <[email protected]>
1 parent 0374016 commit 13acc94

File tree

1 file changed

+22
-5
lines changed

1 file changed

+22
-5
lines changed

net/core/skbuff.c

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3460,6 +3460,19 @@ void *skb_pull_rcsum(struct sk_buff *skb, unsigned int len)
34603460
}
34613461
EXPORT_SYMBOL_GPL(skb_pull_rcsum);
34623462

3463+
static inline skb_frag_t skb_head_frag_to_page_desc(struct sk_buff *frag_skb)
3464+
{
3465+
skb_frag_t head_frag;
3466+
struct page *page;
3467+
3468+
page = virt_to_head_page(frag_skb->head);
3469+
head_frag.page.p = page;
3470+
head_frag.page_offset = frag_skb->data -
3471+
(unsigned char *)page_address(page);
3472+
head_frag.size = skb_headlen(frag_skb);
3473+
return head_frag;
3474+
}
3475+
34633476
/**
34643477
* skb_segment - Perform protocol segmentation on skb.
34653478
* @head_skb: buffer to segment
@@ -3664,15 +3677,19 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,
36643677

36653678
while (pos < offset + len) {
36663679
if (i >= nfrags) {
3667-
BUG_ON(skb_headlen(list_skb));
3668-
36693680
i = 0;
36703681
nfrags = skb_shinfo(list_skb)->nr_frags;
36713682
frag = skb_shinfo(list_skb)->frags;
36723683
frag_skb = list_skb;
3684+
if (!skb_headlen(list_skb)) {
3685+
BUG_ON(!nfrags);
3686+
} else {
3687+
BUG_ON(!list_skb->head_frag);
36733688

3674-
BUG_ON(!nfrags);
3675-
3689+
/* to make room for head_frag. */
3690+
i--;
3691+
frag--;
3692+
}
36763693
if (skb_orphan_frags(frag_skb, GFP_ATOMIC) ||
36773694
skb_zerocopy_clone(nskb, frag_skb,
36783695
GFP_ATOMIC))
@@ -3689,7 +3706,7 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,
36893706
goto err;
36903707
}
36913708

3692-
*nskb_frag = *frag;
3709+
*nskb_frag = (i < 0) ? skb_head_frag_to_page_desc(frag_skb) : *frag;
36933710
__skb_frag_ref(nskb_frag);
36943711
size = skb_frag_size(nskb_frag);
36953712

0 commit comments

Comments
 (0)