Merge pull request #521 from tisnik/lcore-653-better-code-coverate-for-requests-unit-tests

LCORE-653: better code coverage for Requests unit tests

Author: tisnik

tests/unit/models/requests/test_feedback_status_update_request.py

@@ -0,0 +1,23 @@
+"""Unit tests for FeedbackStatusUpdateRequest model."""
+
+from models.requests import FeedbackStatusUpdateRequest
+
+
+class TestFeedbackStatusUpdateRequest:
+    """Test cases for the FeedbackStatusUpdateRequest model."""
+
+    def test_constructor(self) -> None:
+        """Test the FeedbackStatusUpdateRequest constructor."""
+        fs = FeedbackStatusUpdateRequest(status=False)
+        assert fs.status is False
+
+        fs = FeedbackStatusUpdateRequest(status=True)
+        assert fs.status is True
+
+    def test_get_value(self) -> None:
+        """Test the FeedbackStatusUpdateRequest.get_value method."""
+        fs = FeedbackStatusUpdateRequest(status=False)
+        assert fs.get_value() is False
+
+        fs = FeedbackStatusUpdateRequest(status=True)
+        assert fs.get_value() is True

tests/unit/models/requests/test_query_request.py

@@ -22,6 +22,11 @@ def test_constructor(self) -> None:
         assert qr.system_prompt is None
         assert qr.attachments is None
 
+    def test_constructor_wrong_conversation_id(self) -> None:
+        """Test the QueryRequest constructor with wrong conversation_id."""
+        with pytest.raises(ValueError, match="Improper conversation ID 'xyzzy'"):
+            _ = QueryRequest(query="Tell me about Kubernetes", conversation_id="xyzzy")
+
     def test_with_attachments(self) -> None:
         """Test the QueryRequest with attachments."""
         attachments = [

tests/unit/models/responses/test_authorized_response.py

@@ -23,6 +23,9 @@ def test_constructor(self) -> None:
 
     def test_constructor_fields_required(self) -> None:
         """Test the AuthorizedResponse constructor."""
+        with pytest.raises(ValidationError):
+            # missing all parameters
+            _ = AuthorizedResponse()  # pyright: ignore
 
         with pytest.raises(ValidationError):
             # missing user_id parameter