Merge pull request #634 from max-svistunov/lcore-474-unknown-conversation-id

Properly handle unknown conversation_id

Author: tisnik

src/app/endpoints/query.py

@@ -256,15 +256,15 @@ async def query_endpoint_handler(  # pylint: disable=R0914
 
         if user_conversation is None:
             logger.warning(
-                "User %s attempted to query conversation %s they don't own",
-                user_id,
+                "Conversation %s not found for user %s",
                 query_request.conversation_id,
+                user_id,
             )
             raise HTTPException(
-                status_code=status.HTTP_403_FORBIDDEN,
+                status_code=status.HTTP_404_NOT_FOUND,
                 detail={
-                    "response": "Access denied",
-                    "cause": "You do not have permission to access this conversation",
+                    "response": "Conversation not found",
+                    "cause": "The requested conversation does not exist.",
                 },
             )
     else:

tests/unit/app/endpoints/test_query.py

@@ -2030,6 +2030,30 @@ async def test_get_topic_summary_system_prompt_retrieval(mocker):
     mock_get_topic_summary_system_prompt.assert_called_once_with(mock_config)
 
 
+@pytest.mark.asyncio
+async def test_query_endpoint_handler_conversation_not_found(mocker, dummy_request):
+    """Test that a 404 is raised for a non-existant conversation_id."""
+    mock_config = mocker.Mock()
+    mocker.patch("app.endpoints.query.configuration", mock_config)
+
+    mocker.patch(
+        "app.endpoints.query.validate_conversation_ownership", return_value=None
+    )
+
+    query_request = QueryRequest(
+        query="What is OpenStack?",
+        conversation_id="00000000-0000-0000-0000-000000000001",
+    )
+
+    with pytest.raises(HTTPException) as exc_info:
+        await query_endpoint_handler(
+            request=dummy_request, query_request=query_request, auth=MOCK_AUTH
+        )
+
+    assert exc_info.value.status_code == status.HTTP_404_NOT_FOUND
+    assert "Conversation not found" in exc_info.value.detail["response"]
+
+
 @pytest.mark.asyncio
 async def test_get_topic_summary_agent_creation_parameters(mocker):
     """Test that get_topic_summary creates agent with correct parameters."""