[sql-28] firewall+sessions: clean up in preparation for SQL backend #1029
+187
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetGroupID is given a session ID as a param and so should return ErrSessionNotFound if that session is not found. GetSessionIDs is given a groupID as a param and so should return ErrUnknownGroup if that group does not exist. This commit updates the kvstore and sql implementations to return the correct error values and also ensures that this is properly tested now.
In preparation for it clashing with a transaction tx variable in an upcoming commit.
Convert some helpers to be methods on `kvStoreTx` in preparation for some of these helpers needing access to other variables within `kvStoreTx`.
If the is writing to a kvstore that is namespaced by a session's ID, we first assert that the session exists in the session store. We add a test for this accordingly. We do this in preparation for adding a sql backend which will error out if we try to link a kvstore to a session that does not yet exist.
ellemouton
added
no-changelog
bitromortac
reviewed
Apr 8, 2025
|
|
||
| // Get a kvstore namespaced by a session ID for a session that does | ||
| // not exist. | ||
| store := db.GetKVStores("AutoFees", [4]byte{1, 1, 1, 1}, "auto-fees") |
There was a problem hiding this comment.
would it make sense to already error here in case the session is not found, or does this prevent some functionality?
There was a problem hiding this comment.
just cause of how this works under the hood on db types, it makes more sense to have this check at DB access time. THis call doesnt currently make a DB call. Also i think we want Get/Delete to not necessarily error out if the session does not exist yet - those should just return nil, nil
ViktorTigerstrom
approved these changes
Apr 8, 2025
| @@ -376,6 +392,81 @@ func TestKVStoreNameSpaces(t *testing.T) { | |||
| require.True(t, bytes.Equal(v, []byte("thing 3"))) | |||
| } | |||
|
|
|||
| // TestKVStoreSessionCoupling tests if we attempt to write to a kvstore that | |||
| // is namespaced by a session that does not exist, then we should get an error. | |||
| func TestKVStoreSessionCoupling(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we do the last bit of clean up of the bbolt kvstores impl along with the tests of the kvstores.
The main thing this PR does is to assert strong coupling between kvstores and the session it is referencing. We do this in the bbolt implementation so that our unit tests can assert the correct errors. After this, we should be able to just plug in the SQL impl without making any further changes to the kvstore unit tests.
See commit messages for more details.
Part of #917