Skip to content

Commit 20c0eb8

Browse files
multi: add accounts u --new_balance deprecation
This commit adds a deprecation notice regarding the `accounts update --new_balance` flag. This flag will be removed in the next major release of lit.
1 parent 61cb142 commit 20c0eb8

File tree

6 files changed

+107
-90
lines changed

6 files changed

+107
-90
lines changed

cmd/litcli/accounts.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ var updateAccountCommand = cli.Command{
162162
},
163163
cli.Int64Flag{
164164
Name: "new_balance",
165-
Usage: "The new balance of the account; -1 means do " +
166-
"not update the balance.",
165+
Usage: "(deprecated) The new balance of the account; " +
166+
"-1 means do not update the balance.",
167167
Value: -1,
168168
},
169169
cli.Int64Flag{

docs/release-notes/release-notes-0.14.2.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@
3232
allow increasing or decreasing the balance of an off-chain account by a
3333
specified amount.
3434

35+
36+
* The [`accounts update` `--new_balance` flag has been
37+
deprecated](https://github.com/lightninglabs/lightning-terminal/pull/974).
38+
Use the `accounts credit` and `accounts debit` commands instead, to update
39+
an account's balance. The flag will no longer be supported in Lightning
40+
Terminal `v0.15.0-alpha`.
41+
3542
## Integrated Binary Updates
3643

3744
### LND

litrpc/lit-accounts.pb.go

Lines changed: 87 additions & 83 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

litrpc/lit-accounts.proto

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,11 @@ message UpdateAccountRequest {
144144
// The ID of the account to update. Either the ID or the label must be set.
145145
string id = 1;
146146

147-
// The new account balance to set. Set to -1 to not update the balance.
148-
int64 account_balance = 2;
147+
/*
148+
Deprecated, use credit or debit command instead. The new account balance to
149+
set. Set to -1 to not update the balance.
150+
*/
151+
int64 account_balance = 2 [deprecated = true];
149152

150153
/*
151154
The new account expiry to set. Set to -1 to not update the expiry. Set to 0

litrpc/lit-accounts.swagger.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@
278278
"account_balance": {
279279
"type": "string",
280280
"format": "int64",
281-
"description": "The new account balance to set. Set to -1 to not update the balance."
281+
"description": "Deprecated, use credit or debit command instead. The new account balance to\nset. Set to -1 to not update the balance."
282282
},
283283
"expiration_date": {
284284
"type": "string",

proto/lit-accounts.proto

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,11 @@ message UpdateAccountRequest {
144144
// The ID of the account to update. Either the ID or the label must be set.
145145
string id = 1;
146146

147-
// The new account balance to set. Set to -1 to not update the balance.
148-
int64 account_balance = 2 [jstype = JS_STRING];
147+
/*
148+
Deprecated, use credit or debit command instead. The new account balance to
149+
set. Set to -1 to not update the balance.
150+
*/
151+
int64 account_balance = 2 [deprecated = true, jstype = JS_STRING];
149152

150153
/*
151154
The new account expiry to set. Set to -1 to not update the expiry. Set to 0

0 commit comments

Comments
 (0)