Connect to channel peers before creating a channel in tests. #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't do this, then peers are never added to per_peer_state in ChannelManager, causing list_usable_channels to bogusly return our channel peer's features as empty.
|
Oops should've ran the test suite first. Converting to draft. |
|
Maybe do the connection on init instead of when a channel is created? Could probably just connect all peers to each other. |
|
Looks like I'll need this for #1019. @valentinewallace if you're busy with other tasks, I can take this on and fix the test failures. |
|
Superseded by #1024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't do this, then peers are never added to per_peer_state in ChannelManager,
causing list_usable_channels to bogusly return our channel peer's features as empty.
This is what was causing my keysend test to fail due to "unsupported"
var_len_onionfeature.