-
Notifications
You must be signed in to change notification settings - Fork 407
Clean up docs on public chan_utils methods to be more useful #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 90.59% 90.60%
=======================================
Files 60 60
Lines 30393 30393
=======================================
+ Hits 27536 27538 +2
+ Misses 2857 2855 -2
Continue to review full report at Codecov.
|
Lightning-signer is actually using these for test purposes, but I agree it doesn't make a lot of sense to expose and we can copy the small amount of code to our repo. |
Alright, no big deal, we can fix the docs instead of un-exposing :). |
dc9a2b9
to
8f452b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe both could use something about when/why you'd want to call them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after squash
2291457
to
8cdc855
Compare
Squashed without changes:
|
No description provided.