Skip to content

Expose AsyncBlockSourceResult as pub #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valentinewallace
Copy link
Contributor

@valentinewallace valentinewallace commented Mar 25, 2021

Because I want to make a wrapper for RpcClient that implements BlockSource

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #855 (85106c9) into main (8a8c75a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   90.59%   90.60%           
=======================================
  Files          51       51           
  Lines       27109    27109           
=======================================
+ Hits        24560    24562    +2     
+ Misses       2549     2547    -2     
Impacted Files Coverage Δ
lightning-block-sync/src/lib.rs 95.37% <ø> (ø)
lightning/src/ln/functional_tests.rs 96.88% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8c75a...85106c9. Read the comment docs.

Useful for writing objects that implement BlockSource trait.
@valentinewallace valentinewallace force-pushed the expose-asyncblocksourceresult branch from 1904c44 to 85106c9 Compare March 26, 2021 18:54
@TheBlueMatt TheBlueMatt merged commit fe85696 into lightningdevkit:main Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants