Skip to content

Expose channel fees in ChannelDetails #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valentinewallace
Copy link
Contributor

We need this to make route hints for invoices.

We need this to make route hints for invoices.
@valentinewallace valentinewallace force-pushed the listchans-expose-feerates branch from 7064d27 to 7c7c08b Compare March 4, 2021 00:40
@TheBlueMatt
Copy link
Collaborator

Fee charged by us is usually not very useful/interesting, I suppose we could export it, but you almost certainly want the fee charged by our counterparty for inbound information, not the other way around - I believe thats the actual reason for #207.

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #824 (7c7c08b) into main (4894d52) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   90.97%   90.95%   -0.02%     
==========================================
  Files          48       48              
  Lines       26452    26456       +4     
==========================================
- Hits        24064    24063       -1     
- Misses       2388     2393       +5     
Impacted Files Coverage Δ
lightning/src/routing/router.rs 96.86% <ø> (ø)
lightning/src/ln/channelmanager.rs 85.22% <50.00%> (-0.07%) ⬇️
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4894d52...7c7c08b. Read the comment docs.

@valentinewallace
Copy link
Contributor Author

Dangit, OK revising approach...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants