Skip to content

Bump rust-bitcoin and friends #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

TheBlueMatt
Copy link
Collaborator

This is the last step towards getting #618 merged!

Thew new API is a bit harder to misuse by taking a reference to the
transaction to require the inputs match the input being signed.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #686 into master will increase coverage by 0.00%.
The diff coverage is 99.31%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          35       35           
  Lines       21724    21727    +3     
=======================================
+ Hits        19852    19855    +3     
  Misses       1872     1872           
Impacted Files Coverage Δ
lightning/src/ln/channel.rs 87.20% <92.85%> (ø)
lightning/src/chain/chaininterface.rs 91.93% <100.00%> (ø)
lightning/src/chain/keysinterface.rs 94.84% <100.00%> (ø)
lightning/src/ln/chan_utils.rs 95.97% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 85.27% <100.00%> (ø)
lightning/src/ln/channelmonitor.rs 95.49% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 94.81% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.15% <100.00%> (ø)
lightning/src/ln/msgs.rs 90.33% <100.00%> (+0.02%) ⬆️
lightning/src/ln/reorg_tests.rs 98.94% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3defcc8...25b0c2a. Read the comment docs.

@valentinewallace valentinewallace self-requested a review September 10, 2020 21:01
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇 and nice on upgrading to the less error-prone API.

@TheBlueMatt TheBlueMatt merged commit 2dd8b3e into lightningdevkit:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants