Refactor route tests #675
Merged
Refactor route tests #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits up the monolithic test into smaller unit tests * Factors out helpers for graph setup * Changes `id_to_feature_flags` to be a function, there was no reason why it had to be a macro * Activates a previously commented-out test that checks for the failure case in `disable_node_test`
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 35 35
Lines 21703 21719 +16
=======================================
+ Hits 19828 19844 +16
Misses 1875 1875
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #525.
Splits up the monolithic test into smaller unit tests
Factors out helpers for graph setup
Changes
id_to_feature_flagsto be a function, there was noreason why it had to be a macro
Activates a previously commented-out test that checks for
the failure case in
disable_node_test