592+a few fixes #621
Merged
592+a few fixes #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ce2223 introduced a new field in the "Node" objects used in our functional tests - the node_id. Its not a bad idea to cache it, but unless we want to commit and use it everywhere, we should avoid duplicating data, especially in tests where we'd rather exercise the underlying code than bypass it.
Because we expose the internals we don't need a method to log their contents anymore, and get_addresses can now avoid copying as we expose the RwLock directly
We previously were only able to assert that the route graph serialization roundtrips were good by comparing the network messages returned from them, but we can now do better as the graph is exposed publicly via a simple datastructure that implements PartialEq.
We need to always set lowest_inbound_channel_fees to None if there are no channels (and we should ignore the channels which are disabled for the purpose of lowest-fee calculations). Further, we cannot unwrap the channel lookups as they may be for channels which are not related to the channel we are processing an update for. Finally, we can satisfy borrowck much easier since things are on self instead of on a MutexGuard.
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 91.12% 91.17% +0.04%
==========================================
Files 34 35 +1
Lines 20505 20693 +188
==========================================
+ Hits 18686 18866 +180
- Misses 1819 1827 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.