-
Notifications
You must be signed in to change notification settings - Fork 404
rustfmt
: Run on onion_message
#3576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfmt
: Run on onion_message
#3576
Conversation
…m exclusion list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impl< | ||
ES: Deref, | ||
NS: Deref, | ||
L: Deref, | ||
NL: Deref, | ||
MR: Deref, | ||
OMH: Deref, | ||
APH: Deref, | ||
DRH: Deref, | ||
CMH: Deref, | ||
> OnionMessenger<ES, NS, L, NL, MR, OMH, APH, DRH, CMH> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of this but not obvious to me how it can be helped either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for looking out, @valentinewallace and @jkczyz! Really appreciate it! ✨
For the offers message flow refactor, the changes are definitely manageable on my end, so I can take care of any adjustments if this gets merged first.
As for No Path Offer, since it builds on flow, it’ll be a little while before it's ready to merge anyway.
So from my side, I’d say we’re good to go ahead with this one first, and I’ll handle the refactor afterward!
Cool, thanks! Going ahead and landing this. |
We run the formatter on the
onion_message
sub-directory.