Fix lint errors

[arik-so]

CI is currently complaining about lint issues we cannot address without raising our MSRV, so this PR adds some exemptions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (726dd5c) to head (9fefdbb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         130      130           
  Lines      107335   107335           
  Branches   107335   107335           
=======================================
  Hits        96273    96273           
+ Misses       8660     8659    -1     
- Partials     2402     2403    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tnull]

LGTM, feel free to squash the fixup.

Feel free to address the nit while squashing, or ignore it.

[tnull]

Changes are trivial and give us that green checkmark. Merging.

[tnull]

@arik-so Did you have luck running check-lint.sh locally?

I currently get:

> ./ci/check-lint.sh
+ RUSTFLAGS='-D warnings'
+ cargo clippy -- -A clippy::unwrap-or-default -A clippy::erasing_op -A clippy::never_loop -A renamed_and_removed_lints -A clippy::blocks_in_conditions -A clippy::borrow_deref_ref -A clippy::clone_on_copy -A clippy::collapsible_else_if -A clippy::collapsible_if -A clippy::collapsible_match -A clippy::comparison_chain -A clippy::doc_lazy_continuation -A clippy::drain_collect -A clippy::drop_non_drop -A clippy::enum_variant_names -A clippy::explicit_auto_deref -A clippy::extra_unused_lifetimes -A clippy::for_kv_map -A clippy::from_over_into -A clippy::get_first -A clippy::identity_op -A clippy::if_same_then_else -A clippy::inconsistent_digit_grouping -A clippy::iter_kv_map -A clippy::iter_skip_next -A clippy::large_enum_variant -A clippy::legacy_numeric_constants -A clippy::len_without_is_empty -A clippy::len_zero -A clippy::let_and_return -A clippy::manual_div_ceil -A clippy::manual_filter -A clippy::manual_map -A clippy::manual_memcpy -A clippy::manual_inspect -A clippy::manual_range_contains -A clippy::manual_range_patterns -A clippy::manual_saturating_arithmetic -A clippy::manual_strip -A clippy::map_clone -A clippy::map_flatten -A clippy::match_like_matches_macro -A clippy::match_ref_pats -A clippy::multiple_bound_locations -A clippy::mut_mutex_lock -A clippy::needless_bool -A clippy::needless_borrow -A clippy::needless_borrowed_reference -A clippy::needless_borrows_for_generic_args -A clippy::needless_lifetimes -A clippy::needless_question_mark -A clippy::needless_range_loop -A clippy::needless_return -A clippy::new_without_default -A clippy::non_minimal_cfg -A clippy::op_ref -A clippy::option_as_ref_deref -A clippy::option_map_or_none -A clippy::option_map_unit_fn -A clippy::precedence -A clippy::ptr_arg -A clippy::question_mark -A clippy::readonly_write_lock -A clippy::redundant_closure -A clippy::redundant_field_names -A clippy::redundant_guards -A clippy::redundant_pattern_matching -A clippy::redundant_slicing -A clippy::redundant_static_lifetimes -A clippy::result_large_err -A clippy::result_unit_err -A clippy::search_is_some -A clippy::single_char_pattern -A clippy::single_match -A clippy::slow_vector_initialization -A clippy::tabs_in_doc_comments -A clippy::to_string_in_format_args -A clippy::too_many_arguments -A clippy::toplevel_ref_arg -A clippy::type_complexity -A clippy::unnecessary_cast -A clippy::unnecessary_get_then_check -A clippy::unnecessary_lazy_evaluations -A clippy::unnecessary_mut_passed -A clippy::unnecessary_sort_by -A clippy::unnecessary_to_owned -A clippy::unnecessary_unwrap -A clippy::unused_unit -A clippy::useless_conversion
    Checking secp256k1-sys v0.10.1
    Checking possiblyrandom v0.2.0 (/Users/erohrer/workspace/rust-lightning/possiblyrandom)
   Compiling lightning-macros v0.1.0 (/Users/erohrer/workspace/rust-lightning/lightning-macros)
    Checking bitcoin-internals v0.3.0
    Checking bitcoin_hashes v0.14.0
    Checking serde_json v1.0.133
    Checking chrono v0.4.38
error[E0602]: unknown lint: `clippy::manual_div_ceil`
  |
  = help: did you mean: `clippy::manual_filter`
  = note: requested on the command line with `-A clippy::manual_div_ceil`
  = note: `-D unknown-lints` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unknown_lints)]`

error[E0602]: unknown lint: `clippy::manual_inspect`
  |
  = help: did you mean: `clippy::manual_assert`
  = note: requested on the command line with `-A clippy::manual_inspect`

For more information about this error, try `rustc --explain E0602`.
error: could not compile `possiblyrandom` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `lightning-macros` (lib) due to 2 previous errors
error: could not compile `lightning-macros` (lib) due to 2 previous errors
exit 101

[arik-so]

I did, but I was testing some rust beta stuff and imagine it installed a newer version of the dependency