Follow-ups for ChannelManager::create_bolt11_invoice
#3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Nov 12, 2024
lightning/src/ln/channelmanager.rs
Outdated
| }; | ||
|
|
||
| // This may be up to 2 hours in the future because of bitcoin's block time rule or about | ||
| // 10-30 minutes in the past in case of chain reorgs. This should be fine as the payment |
There was a problem hiding this comment.
Well, I mean cause like blocks just sometimes aren't found for 10-30 minutes :)
There was a problem hiding this comment.
Ah, right. That makes more sense. 😛
lightning/src/ln/channelmanager.rs
Outdated
|
|
||
| // This may be up to 2 hours in the future because of bitcoin's block time rule or about | ||
| // 10-30 minutes in the past in case of chain reorgs. This should be fine as the payment | ||
| // secret includes a two hour buffer to ensure payments aren't failed too early. |
There was a problem hiding this comment.
My concern was really more the payment actually timing out in the invoice, causing the sender to not pay even though the invoice is still valid. IIRC the invoice default expiry is still two hours, tho, so we have some time.
There was a problem hiding this comment.
Updated and also expand the user-facing docs.
jkczyz
force-pushed
the
2024-11-bolt11-invoice-utils-follow-up
branch
from
035212f to
20ef217
Compare
TheBlueMatt
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some minor comments from #3389.