Add balance and is_live fields to ChannelDetails #340
Conversation
| /// Note that there are some corner cases not fully handled here, so the actual available | ||
| /// inbound capacity may be slightly higher than this. | ||
| pub inbound_capacity_msat: u64, | ||
| /// True if the channel is (a) confirmed and funding_locked messages have been exchanged, (b) |
There was a problem hiding this comment.
What's about channel_update with disable flags set ? Or if we detect channel transaction but closing hasn't get enough confs (and so channel isn't prune yet from channel graph) ?
There was a problem hiding this comment.
As for (a), we handle that in Router, and I'm still pretty confused as to how a peer can send that to you and have you do anything, do we implement it yet anyway?, as for (b) I think we prune it immediately, no?
There was a problem hiding this comment.
Okay, so "liveness" is just a ChannelManager view-based and doesn't rely on what the Router may receive (like a channel_update from peer disabling this channel, which is not implemented yet because #207 is still on stand-by)
There was a problem hiding this comment.
I think #207 should result in the Channel knowing if the counterparty sent us a channel_update disabling our own channel, then we could view it, but, yes.
TheBlueMatt
force-pushed
the
2019-06-channeldetails-fields
branch
from
bec6432 to
3d55d71
Compare
This came up at lightning hack day munich as a useful field, and is pretty trivial to add.