Re-export bitcoin crate #3068
Merged
Re-export bitcoin crate #3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the same reason the `bitcoin` crate is re-exporting the `secp256k1` crate the `lightning` crate should re-export the `bitcoin` crate: to ease the burden on calling code to maintain compatible `bitcoin` versions. The `lightning` crate makes heavy use of types defined in (or re-exported by) the `bitcoin` crate. Compilation will fail if e.g. comparisons or `match` expressions are done with types from `bitcoin` crate versions with a non-equal minor version. This forces calling code to depend on a `bitcoin` crate with a compatible version. This becomes a maintenance nightmare once two or more crates, that use `bitcoin` types in their public API, are used in calling code simultaneously.
TheBlueMatt
approved these changes
May 17, 2024
tnull
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the same reason the
bitcoincrate is re-exporting thesecp256k1crate thelightningcrate should re-export thebitcoincrate: to ease the burden on calling code to maintain compatiblebitcoinversions.The
lightningcrate makes heavy use of types defined in (or re-exported by) thebitcoincrate. Compilation will fail if e.g. comparisons ormatchexpressions are done with types frombitcoincrate versions with a non-equal minor version. This forces calling code to depend on abitcoincrate with a compatible version. This becomes a maintenance nightmare once two or more crates, that usebitcointypes in their public API, are used in calling code simultaneously.