Follow-ups to #2970 #3028
Merged
Follow-ups to #2970 #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TheBlueMatt
previously approved these changes
Apr 29, 2024
valentinewallace
previously approved these changes
Apr 29, 2024
PaymentContext is already stored in ClaimablePayment via PaymentPurpose, so there is no need to repeat it in each ClaimableHTLC via OnionPayload. This avoids cloning the PaymentContext each time an HTLC is received, other than for the first HTLC for a payment.
Event::PaymentClaimable and Event::PaymentClaimed already contain the paid amount, so there's no need to included the requested amount in InvoiceRequestFields.
InvoiceRequestFeatures may contain a large, odd bit. Including this in InvoiceRequestFields, which is in each BlindedPath of a Bolt12Invoice, could cause the invoice's onion message to exceed the maximum size. The features are already checked before sending an invoice.
jkczyz
dismissed stale reviews from valentinewallace and TheBlueMatt
via
33b6162
jkczyz
force-pushed
the
2024-04-offer-id-followups
branch
from
11fda41 to
33b6162
Compare
valentinewallace
approved these changes
Apr 29, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
+ Coverage 89.13% 89.48% +0.35%
==========================================
Files 118 118
Lines 97492 99913 +2421
Branches 97492 99913 +2421
==========================================
+ Hits 86903 89411 +2508
+ Misses 8349 8246 -103
- Partials 2240 2256 +16 ☔ View full report in Codecov by Sentry. |
|
CI is failing, though it seems unrelated. |
|
CI failures are some new warning on beta, not related. |
TheBlueMatt
approved these changes
Apr 29, 2024
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
May 6, 2024
…followups Follow-ups to lightningdevkit#2970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unnecessary clones when handling HTLCs and unnecessary / problematic TLVs from
InvoiceRequestFields.