Fix a few monitor-update failure bugs found by new fuzzer #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
from
b56f05b to
afdff76
Compare
|
Needless rebase to make #288 clearly based on this. |
ariard
reviewed
Jan 18, 2019
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
from
afdff76 to
23eddc8
Compare
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
2 times, most recently
from
9c7a5b5 to
2aa8fea
Compare
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
from
2aa8fea to
fafabc7
Compare
Primarily this fixes the case where we receive an RAA which does not require a response, allowing us to call monitor_update_failed without generating pending messages.
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
from
fafabc7 to
23abe2b
Compare
|
Rebased so its now freestanding, gonna go ahead and take this. |
TheBlueMatt
force-pushed
the
2019-01-monitor-update-fixes
branch
from
23abe2b to
be8213b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing a new fuzz target I dug up a few existing bugs, this fixes two of them with new tests.