Simplify and expand logging in is_resolving_htlc_output #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
changed the title
TheBlueMatt
force-pushed
the
2019-01-htlc-resolution-log
branch
from
f79b74d to
9e6a369
Compare
TheBlueMatt
force-pushed
the
2019-01-htlc-resolution-log
branch
from
9e6a369 to
0baf07e
Compare
ariard
reviewed
Jan 9, 2019
ariard
reviewed
Jan 9, 2019
ariard
reviewed
Jan 9, 2019
ariard
approved these changes
Jan 9, 2019
When our counterparty claims multiple HTLCs from offered outputs in one transaction we should still be able to learn the preimages. Sadly, due to two bugs we were not previously doing so.
This clarifies all the conditions we can hit and also ensures they are all logged in a clear and consistent manner.
TheBlueMatt
force-pushed
the
2019-01-htlc-resolution-log
branch
from
0baf07e to
90ce971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #282 since they conflict.