Fix final incorrect cltv #2639
Merged
Fix final incorrect cltv #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2639 +/- ##
==========================================
- Coverage 88.99% 88.96% -0.04%
==========================================
Files 112 112
Lines 87168 87191 +23
Branches 87168 87191 +23
==========================================
- Hits 77575 77567 -8
- Misses 7353 7384 +31
Partials 2240 2240
☔ View full report in Codecov by Sentry. |
vladimirfomene
force-pushed
the
fix-final-incorrect-cltv
branch
from
4df3797 to
f51a1e5
Compare
vladimirfomene
force-pushed
the
fix-final-incorrect-cltv
branch
4 times, most recently
from
3325025 to
5036e21
Compare
wpaulino
reviewed
Oct 10, 2023
|
You might need to push again, GitHub is stuck "processing updates" on the PR. |
vladimirfomene
force-pushed
the
fix-final-incorrect-cltv
branch
from
0e91028 to
12ee4b4
Compare
valentinewallace
previously approved these changes
Oct 12, 2023
As noted in BOLT 4, we should be using the update_add_htlc's cltv_expiry, not the CLTV expiry set by the sender in the onion for this comparison. See here: https://github.com/lightning/bolts/blob/4dcc377209509b13cf89a4b91fde7d478f5b46d8/04-onion-routing.md?plain=1#L334
vladimirfomene
force-pushed
the
fix-final-incorrect-cltv
branch
from
12ee4b4 to
33715e8
Compare
valentinewallace
approved these changes
Oct 13, 2023
wpaulino
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2513