Add a method to get session secret for onion packet to KeysInterface #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, looks good, need to get implemented in full_stack_target, though. |
|
oops. fixed. |
TheBlueMatt
reviewed
Nov 26, 2018
src/chain/keysinterface.rs
Outdated
|
|
||
| fn get_session_key(&self) -> SecretKey { | ||
| let child_ix = self.session_child_index.fetch_add(1, Ordering::AcqRel); | ||
| self.session_master_key.ckd_priv(&self.secp_ctx, ChildNumber::from_hardened_idx(child_ix as u32)).expect("Your RNG is busted").secret_key |
There was a problem hiding this comment.
Oops, sorry, this isnt sufficient as it'll wrap back to 0 on restart and we'll re-use session keys. Can you hash in the timestamp like we do for channel keys? I'm not too worried about needing extra rng output, here, though.
| @@ -265,6 +265,10 @@ impl KeysInterface for KeyProvider { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| fn get_session_key(&self) -> SecretKey { | |||
| SecretKey::from_slice(&Secp256k1::without_caps(), &[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]).unwrap() | |||
There was a problem hiding this comment.
Oops, please avoid changing the keys used in things in the fuzz targets. You can just take TheBlueMatt@5a82977, I think.
yuntai
force-pushed
the
201811-sessionkey
branch
from
d0bc6c3 to
ca183cf
Compare
|
updated. not sure ...expect("RNG is busted") is correct things to print out |
|
Looks good, sans the compile error that broke travis. |
yuntai
force-pushed
the
201811-sessionkey
branch
from
ca183cf to
7e59e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per
#243 (comment)