Skip to content

Print contents of our own channel updates #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

Sharmalm
Copy link
Contributor

This pr solve this #2467 issue

@TheBlueMatt
Copy link
Collaborator

I think you can replace the existing one, rather than only adding a new log. Also please squash the commits down into a single commit with a descriptive title (no more than 60 chars long)

@jbesraa
Copy link
Contributor

jbesraa commented Aug 23, 2023

you can find useful info here about git/commit history structure

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -90.60% ⚠️

Comparison is base (4fb5708) 90.59% compared to head (863e19f) 0.00%.
Report is 54 commits behind head on main.

❗ Current head 863e19f differs from pull request most recent head cdedc79. Consider uploading reports for the commit cdedc79 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2516       +/-   ##
==========================================
- Coverage   90.59%       0   -90.60%     
==========================================
  Files         106       0      -106     
  Lines       56577       0    -56577     
  Branches    56577       0    -56577     
==========================================
- Hits        51258       0    -51258     
+ Misses       5319       0     -5319     

see 106 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sharmalm
Copy link
Contributor Author

Thanks , I'll keep in mind from now on

@TheBlueMatt
Copy link
Collaborator

Please squash your three commits down into one - we don't allow individual commits which fail to build/test (or multiple commits in the same PR which fix issues introduced in previous commits in the same PR).

@Sharmalm
Copy link
Contributor Author

Hello everyone , How to reopen this pr , when i "sync fork" in my forked repo of rust-lightning , this pr gets closed,please help me :)

@valentinewallace
Copy link
Contributor

Sometimes GitHub doesn't let you reopen PRs when they're closed, may want to just open a new one.

@Sharmalm
Copy link
Contributor Author

Ok , i'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants