Update to rust-bitcoin v0.15

[stevenroose]

There is a strange failure in one test that I can't figure out:

https://gist.github.com/stevenroose/8a1ad0a1b4eaf29f35d41c8aa0d7bd96

[ariard]

Issue is into create_chan_between_nodes_with_value_init, https://github.com/rust-bitcoin/rust-lightning/blob/a932fb3ab0315a7eddc6b1f11adb3d4fbd3f70f1/src/ln/channelmanager.rs#L3521, we return a Transaction but register an OutPoint generated from tx serialization. Txids differ from then, not the case with 0.14
Seems to me that's coming from the set of changes on serialization stuff in rust-bitcoin 0.15

[stevenroose]

Can't you use tx.bitcoin_hash() there? Might be related to including segwit data.

[stevenroose]

Using .txid() solved it.

[apoelstra]

Test failures are likely caused by rust-bitcoin/rust-bitcoin#153 which change to use segwit serialization for 0-input transactions. But this code was always incorrect for any transaction with witnesses.

[TheBlueMatt]

Thanks!

[stevenroose]

fixed and rebased