Expose DefaultMessageRouter
#2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Jul 7, 2023
tnull
force-pushed
the
2023-07-expose-default-message-router
branch
from
57500ae to
73ba28d
Compare
jkczyz
approved these changes
Jul 7, 2023
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 106 106
Lines 54965 54965
Branches 54965 54965
=======================================
Hits 49647 49647
Misses 5318 5318 ☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2384 we introduced a
DefaultMessageRouterthat can be given toOnionMessenger.Except it can't as it's not exposed currently. Here, we fix this omission.