Skip to content

Derive a PartialEq and Eq for PaymentError #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023

Conversation

benthecarman
Copy link
Contributor

@benthecarman benthecarman commented May 23, 2023

This lets users compare error types more easily without needing a match
statement.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (498f233) 90.87% compared to head (3003f7d) 90.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   90.87%   90.79%   -0.08%     
==========================================
  Files         104      104              
  Lines       52926    53033     +107     
  Branches    52926    53033     +107     
==========================================
+ Hits        48094    48153      +59     
- Misses       4832     4880      +48     
Impacted Files Coverage Δ
lightning-invoice/src/payment.rs 89.11% <0.00%> (ø)
lightning/src/ln/outbound_payment.rs 89.61% <0.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benthecarman benthecarman force-pushed the payment-err-dervies branch from f20e435 to c34bccd Compare May 24, 2023 20:40
@benthecarman benthecarman changed the title Derive a bunch of traits for PaymentError Derive a PartialEq and Eq for PaymentError May 24, 2023
This lets users compare error types more easily without needing a match
statement.
@benthecarman benthecarman force-pushed the payment-err-dervies branch from c34bccd to 3003f7d Compare May 24, 2023 22:40
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The commit message is wrong: This lets users compare error types more easily without needing a match statement.

Nvm, misread.

@wpaulino wpaulino merged commit 4dce209 into lightningdevkit:main May 25, 2023
@benthecarman benthecarman deleted the payment-err-dervies branch May 25, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants