-
Notifications
You must be signed in to change notification settings - Fork 407
Move keysinterface.rs to a directory-level module called sign #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.01%
==========================================
Files 104 104
Lines 51949 51949
Branches 51949 51949
==========================================
- Hits 47597 47592 -5
- Misses 4352 4357 +5
☔ View full report in Codecov by Sentry. |
2e1357b
to
eeffac7
Compare
LGTM, why is this a draft? |
I wasn't sure if people would want me to add some more subdivision in this PR, like the entropy source, for example. I'm undrafting it. |
Two PRs better than one :) |
Will let @jkczyz comment as he'd previously proposed other naming at #2159 (comment) |
This should be tagged as closing #2157 |
@jkczyz and I also discussed this out of band in Austin. |
eeffac7
to
6cb9919
Compare
Fixes #2157.