Skip to content

Move keysinterface.rs to a directory-level module called sign #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Apr 28, 2023

Fixes #2157.

@wpaulino wpaulino added this to the 0.0.116 milestone Apr 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (ec3de62) 91.62% compared to head (6cb9919) 91.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
- Coverage   91.62%   91.61%   -0.01%     
==========================================
  Files         104      104              
  Lines       51949    51949              
  Branches    51949    51949              
==========================================
- Hits        47597    47592       -5     
- Misses       4352     4357       +5     
Impacted Files Coverage Δ
lightning-background-processor/src/lib.rs 83.18% <ø> (ø)
lightning-block-sync/src/init.rs 92.57% <ø> (ø)
lightning-invoice/src/payment.rs 89.11% <ø> (ø)
lightning-invoice/src/utils.rs 97.17% <ø> (ø)
lightning-persister/src/lib.rs 89.25% <ø> (ø)
lightning/src/blinded_path/mod.rs 93.18% <ø> (ø)
lightning/src/chain/chainmonitor.rs 94.65% <ø> (ø)
lightning/src/chain/channelmonitor.rs 94.82% <ø> (ø)
lightning/src/chain/mod.rs 80.95% <ø> (ø)
lightning/src/chain/onchaintx.rs 92.54% <ø> (-0.35%) ⬇️
... and 37 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arik-so arik-so force-pushed the 2023-04-sign-module branch from 2e1357b to eeffac7 Compare April 28, 2023 21:12
@TheBlueMatt
Copy link
Collaborator

LGTM, why is this a draft?

@arik-so
Copy link
Contributor Author

arik-so commented May 1, 2023

I wasn't sure if people would want me to add some more subdivision in this PR, like the entropy source, for example. I'm undrafting it.

@arik-so arik-so marked this pull request as ready for review May 1, 2023 18:33
wpaulino
wpaulino previously approved these changes May 1, 2023
@TheBlueMatt
Copy link
Collaborator

Two PRs better than one :)

@TheBlueMatt
Copy link
Collaborator

Will let @jkczyz comment as he'd previously proposed other naming at #2159 (comment)

@TheBlueMatt
Copy link
Collaborator

This should be tagged as closing #2157

@arik-so
Copy link
Contributor Author

arik-so commented May 3, 2023

@jkczyz and I also discussed this out of band in Austin.

@arik-so arik-so requested a review from wpaulino May 3, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename lightning/src/chain/keysinterface.rs to something like signer.rs
5 participants