Prevent unnecessary CI workflow runs #2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This master branch is just an alias to the main branch for legacy reasons, so there's no need to run workflows on both branches.
At times, PRs can go through multiple pushes in a short amount of time, spawning a workflow run for each. Most of the time, there's no need to let the previous jobs running if the code itself has changed (e.g., via a force push), and we'd benefit from having those slots be used by other PRs/branches instead.
wpaulino
force-pushed
the
ci-ignore-master-cancel-prev
branch
from
7db7232 to
d63006d
Compare
TheBlueMatt
approved these changes
Apr 17, 2023
|
Heh, feel free to browse through https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions to confirm the behavior here. |
dunxen
reviewed
Apr 17, 2023
Comment on lines
+4
to
+9
| push: | ||
| branches-ignore: | ||
| - master | ||
| pull_request: | ||
| branches-ignore: | ||
| - master |
There was a problem hiding this comment.
Do we mean main here? Also does this mean merges to main won't kick off CI anymore?
There was a problem hiding this comment.
No, we just want to prevent any workflows from running on the master branch. Whether it resulted from a merged PR into main (which is then replayed on master) or from a PR attempting to merge into master (all PRs should go to main) shouldn't matter.
dunxen
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.