Skip to content

Fix out-of-date create_inbound_payment() docs #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danielgranhao
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 87.35% // Head: 87.34% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (dab08c1) compared to base (41a6c67).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   87.35%   87.34%   -0.01%     
==========================================
  Files          99       99              
  Lines       43756    43756              
  Branches    43756    43756              
==========================================
- Hits        38224    38220       -4     
- Misses       5532     5536       +4     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 86.92% <ø> (ø)
lightning/src/chain/onchaintx.rs 85.61% <0.00%> (-0.69%) ⬇️
lightning/src/ln/functional_tests.rs 97.18% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 50a39b9 into lightningdevkit:main Feb 10, 2023
@TheBlueMatt
Copy link
Collaborator

Pretty pissed cargo doc let us get away with this.

@tnull
Copy link
Contributor

tnull commented Feb 10, 2023

Pretty pissed cargo doc let us get away with this.

Reported this upstream.

@TheBlueMatt
Copy link
Collaborator

Already fixed! Nice.

@tnull
Copy link
Contributor

tnull commented Feb 12, 2023

Already fixed! Nice.

Didn't expect that quick turnaround time. I'm impressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants