Introduce a Channel-specific Err type and return it in a few places #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is way simpler than writing out the whole ErrorAction mess and we can just convert it as appropriate in ChannelManager.
yuntai
reviewed
Oct 1, 2018
| ChannelError::Ignore(msg) => HandleError { | ||
| err: msg, | ||
| action: Some(msgs::ErrorAction::IgnoreError), | ||
| }, |
There was a problem hiding this comment.
is action: None different from Some(IgnoreError)?
There was a problem hiding this comment.
action: None -> Not yet filled in (ie TODO), action: Some(IgnoreError) -> Just stop procsesing without error.
|
Concept ACK, I'll have more time tomorrow to review it if you still need it! |
|
It's not super interesting on its own (and only has one functional change - in the update_fail_malformed_htlc proceeding in ChannelManager) more about teeing up continuing refactors to make #153 a bit easier and make things in Channel less verbose.
…On October 1, 2018 2:06:29 AM UTC, ariard ***@***.***> wrote:
Concept ACK, I'll have more time tomorrow to review it if you still
need it!
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#201 (comment)
|
|
Ah okay, I've had quick skim on it, looked the update_fail_malformed_htlc, nothing shocks me feel free to go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is way simpler than writing out the whole ErrorAction mess and we can just convert it as appropriate in ChannelManager. This may make #153 a bit easier to address - by using an intermediate Err type we can just say "fail this channel, but ChannelManager can figure out if we should ban/disconnect/etc based on whether we have other channels with this peer". It also has no Options for actions, which steps us forward on #129 for BOLT 2 as we migrate to it.