Skip to content

Split up KeysInterface parameters into its comprising traits. #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Jan 14, 2023

No description provided.

@arik-so arik-so force-pushed the 2023-01-keys-interface-removal-chunked branch from c8f6bd2 to 5b6f16a Compare January 14, 2023 03:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Base: 90.73% // Head: 90.74% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5b6f16a) compared to base (5221e4a).
Patch coverage: 97.63% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1952    +/-   ##
========================================
  Coverage   90.73%   90.74%            
========================================
  Files          97       97            
  Lines       50539    51035   +496     
  Branches    50539    51035   +496     
========================================
+ Hits        45859    46311   +452     
- Misses       4680     4724    +44     
Impacted Files Coverage Δ
lightning-block-sync/src/init.rs 91.11% <ø> (ø)
lightning/src/chain/keysinterface.rs 83.81% <ø> (ø)
lightning/src/ln/chan_utils.rs 93.56% <ø> (ø)
lightning/src/ln/onion_route_tests.rs 97.64% <ø> (ø)
lightning/src/ln/payment_tests.rs 98.73% <ø> (ø)
lightning/src/ln/priv_short_conf_tests.rs 96.54% <ø> (ø)
lightning/src/ln/reorg_tests.rs 100.00% <ø> (ø)
lightning/src/ln/shutdown_tests.rs 96.51% <ø> (ø)
lightning/src/routing/router.rs 90.90% <ø> (+0.03%) ⬆️
lightning/src/routing/scoring.rs 95.91% <ø> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt
Copy link
Collaborator

Landed the version in #1930 because it already had an ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants