Rework unwrap() call in persistence
#1941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-21
force-pushed
the
feature/rework-unwrap
branch
from
9e52f3e to
66046a7
Compare
Codecov ReportBase: 90.74% // Head: 90.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
==========================================
- Coverage 90.74% 90.72% -0.03%
==========================================
Files 96 96
Lines 50133 50135 +2
Branches 50133 50135 +2
==========================================
- Hits 45493 45483 -10
- Misses 4640 4652 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheBlueMatt
reviewed
Jan 7, 2023
lightning-persister/src/lib.rs
Outdated
| let filename = owned_file_name.to_str(); | ||
| if !filename.is_some() || !filename.unwrap().is_ascii() || filename.unwrap().len() < 65 { | ||
| let filename = owned_file_name.to_str() | ||
| .ok_or_else(|| std::io::Error::new(std::io::ErrorKind::InvalidData, |
There was a problem hiding this comment.
Please indent with a single tab.
There was a problem hiding this comment.
Fixed. It is a work for fmt of course... ;)
lightning-persister/src/lib.rs
Outdated
| if !filename.is_some() || !filename.unwrap().is_ascii() || filename.unwrap().len() < 65 { | ||
| let filename = owned_file_name.to_str() | ||
| .ok_or_else(|| std::io::Error::new(std::io::ErrorKind::InvalidData, | ||
| "File name is not a valid utf8 string"))?; |
There was a problem hiding this comment.
Same here, no need to push this to the end of the line.
andrei-21
force-pushed
the
feature/rework-unwrap
branch
from
66046a7 to
a320ebc
Compare
tnull
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use idiomatic
Result::map_err()andOption::ok_or_else()instead of nakedunwrap().