Skip to content

#[derive(Clone)] for InFlightHtlcs #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

This is useful for bindings, and generally isn't a bad thing for users to have access to.

This is useful for bindings, and generally isn't a bad thing for
users to have access to.
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 90.78% // Head: 90.76% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9414830) compared to base (f0c181e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.02%     
==========================================
  Files          96       96              
  Lines       50080    50082       +2     
  Branches    50080    50082       +2     
==========================================
- Hits        45464    45458       -6     
- Misses       4616     4624       +8     
Impacted Files Coverage Δ
lightning/src/routing/router.rs 90.83% <0.00%> (-0.07%) ⬇️
lightning/src/chain/onchaintx.rs 94.54% <0.00%> (-0.84%) ⬇️
lightning/src/ln/functional_tests.rs 97.00% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arik-so arik-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it solve some of the instances where we pass non-cloneable objects by value?

@TheBlueMatt
Copy link
Collaborator Author

does it solve some of the instances where we pass non-cloneable objects by value?

Yes.

@TheBlueMatt TheBlueMatt merged commit dc39799 into lightningdevkit:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants