Skip to content

Allow duplicate-payment_hash HTLCs for HTLC forwards #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2018
Merged

Allow duplicate-payment_hash HTLCs for HTLC forwards #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b49837
Split HTLC tracking into separate Inbound/Outbound types
TheBlueMatt Sep 9, 2018
da5d707
Allow duplicate-payment_hash HTLCs for HTLC forwards
TheBlueMatt Sep 11, 2018
6b3cc8b
Avoid cross-test statics in ChannelManager network tests
TheBlueMatt Sep 9, 2018
0a65255
Add simple test for duplicate-payment_hash HTLC tracking
TheBlueMatt Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fuzz/fuzz_targets/channel_target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use bitcoin::util::hash::Sha256dHash;
use bitcoin::network::serialize::{serialize, BitcoinHash};

use lightning::ln::channel::{Channel, ChannelKeys};
use lightning::ln::channelmanager::{HTLCFailReason, PendingHTLCStatus};
use lightning::ln::channelmanager::{HTLCFailReason, HTLCSource, PendingHTLCStatus};
use lightning::ln::msgs;
use lightning::ln::msgs::{MsgDecodable, ErrorAction};
use lightning::chain::chaininterface::{FeeEstimator, ConfirmationTarget};
Expand Down Expand Up @@ -269,7 +269,7 @@ pub fn do_test(data: &[u8]) {
loop {
match get_slice!(1)[0] {
0 => {
test_err!(channel.send_htlc(slice_to_be64(get_slice!(8)), [42; 32], slice_to_be32(get_slice!(4)), msgs::OnionPacket {
test_err!(channel.send_htlc(slice_to_be64(get_slice!(8)), [42; 32], slice_to_be32(get_slice!(4)), HTLCSource::dummy(), msgs::OnionPacket {
version: get_slice!(1)[0],
public_key: PublicKey::from_slice(&secp_ctx, get_slice!(33)),
hop_data: [0; 20*65],
Expand Down
Loading